Home Home > GIT Browse
diff options
authorEric Dumazet <edumazet@google.com>2014-04-03 09:28:10 -0700
committerDavid S. Miller <davem@davemloft.net>2014-04-03 16:17:52 -0400
commite33d0ba8047b049c9262fdb1fcafb93cb52ceceb (patch)
parent240a12d58e3935945c8c0f767134f3da1ac05371 (diff)
net-gro: reset skb->truesize in napi_reuse_skb()
Recycling skb always had been very tough... This time it appears GRO layer can accumulate skb->truesize adjustments made by drivers when they attach a fragment to skb. skb_gro_receive() can only subtract from skb->truesize the used part of a fragment. I spotted this problem seeing TcpExtPruneCalled and TcpExtTCPRcvCollapsed that were unexpected with a recent kernel, where TCP receive window should be sized properly to accept traffic coming from a driver not overshooting skb->truesize. Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index 75e88e0372cb..577701839f52 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4043,6 +4043,7 @@ static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb)
skb->vlan_tci = 0;
skb->dev = napi->dev;
skb->skb_iif = 0;
+ skb->truesize = SKB_TRUESIZE(skb_end_offset(skb));
napi->skb = skb;