Home Home > GIT Browse
diff options
authorLinus Torvalds <torvalds@linux-foundation.org>2012-07-07 10:17:00 -0700
committerBen Hutchings <ben@decadent.org.uk>2012-07-12 04:32:20 +0100
commitf6d2d473ca73cb30cf25a6940b1dff3cc78b513f (patch)
parent90f81e29765bd976bf083b239ad04e7f64ab5269 (diff)
vfs: make O_PATH file descriptors usable for 'fchdir()'
commit 332a2e1244bd08b9e3ecd378028513396a004a24 upstream. We already use them for openat() and friends, but fchdir() also wants to be able to use O_PATH file descriptors. This should make it comparable to the O_SEARCH of Solaris. In particular, O_PATH allows you to access (not-quite-open) a directory you don't have read persmission to, only execute permission. Noticed during development of multithread support for ksh93. Reported-by: ольга крыжановская <olga.kryzhanovska@gmail.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/open.c b/fs/open.c
index 22c41b543f2d..e2b5d515bfc9 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -396,10 +396,10 @@ SYSCALL_DEFINE1(fchdir, unsigned int, fd)
struct file *file;
struct inode *inode;
- int error;
+ int error, fput_needed;
error = -EBADF;
- file = fget(fd);
+ file = fget_raw_light(fd, &fput_needed);
if (!file)
goto out;
@@ -413,7 +413,7 @@ SYSCALL_DEFINE1(fchdir, unsigned int, fd)
if (!error)
set_fs_pwd(current->fs, &file->f_path);
- fput(file);
+ fput_light(file, fput_needed);
return error;