Home Home > GIT Browse
diff options
authorSagi Grimberg <sagig@mellanox.com>2015-06-04 19:49:21 +0300
committerNicholas Bellinger <nab@linux-iscsi.org>2015-06-08 22:17:09 -0700
commit524630d5824c7a75aab568c6bd1423fd748cd3bb (patch)
parent2f1b6b7d9a815f341b18dfd26a363f37d4d3c96a (diff)
iser-target: Fix possible use-after-free
iser connection termination process happens in 2 stages: - isert_wait_conn: - resumes rdma disconnect - wait for session commands - wait for flush completions (post a marked wr to signal we are done) - wait for logout completion - queue work for connection cleanup (depends on disconnected/timewait events) - isert_free_conn - last reference put on the connection In case we are terminating during IOs, we might be posting send/recv requests after we posted the last work request which might lead to a use-after-free condition in isert_handle_wc. After we posted the last wr in isert_wait_conn we are guaranteed that no successful completions will follow (meaning no new work request posts may happen) but other flush errors might still come. So before we put the last reference on the connection, we repeat the process of posting a marked work request (isert_wait4flush) in order to make sure all pending completions were flushed. Signed-off-by: Sagi Grimberg <sagig@mellanox.com> Signed-off-by: Jenny Falkovich <jennyf@mellanox.com> Cc: stable@vger.kernel.org # 3.10+ Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index bad1f5d32227..575a072d765f 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -3392,6 +3392,7 @@ static void isert_free_conn(struct iscsi_conn *conn)
struct isert_conn *isert_conn = conn->context;
+ isert_wait4flush(isert_conn);