Home Home > GIT Browse
diff options
authorNicholas Bellinger <nab@linux-iscsi.org>2014-06-10 04:03:54 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-06-30 20:14:00 -0700
commit7b93e2d1bc8076a6d9649249397d9e703fa3e2d0 (patch)
parente6a77ef4776bd9c5ed70db30b8835b094442dbd1 (diff)
iscsi-target: Fix ABORT_TASK + connection reset iscsi_queue_req memory leak
commit bbc050488525e1ab1194c27355f63c66814385b8 upstream. This patch fixes a iscsi_queue_req memory leak when ABORT_TASK response has been queued by TFO->queue_tm_rsp() -> lio_queue_tm_rsp() after a long standing I/O completes, but the connection has already reset and waiting for cleanup to complete in iscsit_release_commands_from_conn() -> transport_generic_free_cmd() -> transport_wait_for_tasks() code. It moves iscsit_free_queue_reqs_for_conn() after the per-connection command list has been released, so that the associated se_cmd tag can be completed + released by target-core before freeing any remaining iscsi_queue_req memory for the connection generated by lio_queue_tm_rsp(). Cc: Thomas Glanzmann <thomas@glanzmann.de> Cc: Charalampos Pournaris <charpour@gmail.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 9189bc0a87ae..dbc4ee4e089e 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -4234,8 +4234,6 @@ int iscsit_close_connection(
if (conn->conn_transport->iscsit_wait_conn)
- iscsit_free_queue_reqs_for_conn(conn);
* During Connection recovery drop unacknowledged out of order
* commands for this connection, and prepare the other commands
@@ -4252,6 +4250,7 @@ int iscsit_close_connection(
+ iscsit_free_queue_reqs_for_conn(conn);
* Handle decrementing session or connection usage count if