Home Home > GIT Browse
diff options
authorKees Cook <keescook@chromium.org>2013-05-10 14:48:21 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-06-20 11:28:20 -0700
commit720083f1dc15ac6b6fb85b323d0eae1a151e20ce (patch)
parentae02c5a7cd1ed15da0976a44b8d0da4ad5c0975d (diff)
b43: stop format string leaking into error msgs
commit e0e29b683d6784ef59bbc914eac85a04b650e63c upstream. The module parameter "fwpostfix" is userspace controllable, unfiltered, and is used to define the firmware filename. b43_do_request_fw() populates ctx->errors[] on error, containing the firmware filename. b43err() parses its arguments as a format string. For systems with b43 hardware, this could lead to a uid-0 to ring-0 escalation. CVE-2013-2852 Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: John W. Linville <linville@tuxdriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 7c2e09a1cc04..4db716b64b9a 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -2309,7 +2309,7 @@ static int b43_request_firmware(struct b43_wldev *dev)
for (i = 0; i < B43_NR_FWTYPES; i++) {
errmsg = ctx->errors[i];
if (strlen(errmsg))
- b43err(dev->wl, errmsg);
+ b43err(dev->wl, "%s", errmsg);
b43_print_fw_helptext(dev->wl, 1);
err = -ENOENT;