Home Home > GIT Browse
diff options
authorAlan Cox <alan@lxorguk.ukuu.org.uk>2009-04-14 14:57:36 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2009-06-15 09:40:16 -0700
commitfb6fda072d7ef219039cc0b0e8218e5f465ef02e (patch)
parentf71cf2a2181aef25513272991f54148799ddc1f0 (diff)
cdc-acm: Fix long standing abuse of tty->low_latency
commit 7a9a65ced11ece416b730d6f21040a18e62d78a8 upstream. ACM sets the low latency flag but calls the flip buffer routines from IRQ context which isn't permitted (and as of 2.6.29 causes a warning hence this one was caught) Fortunatelt ACM doesn't need to set this flag in the first place as it only set it to work around problems in ancient (pre tty flip rewrite) kernels. Reported-by: Chuck Ebbert <cebbert@redhat.com> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index b3d5a23ab56f..7f2909aa8e72 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -546,10 +546,6 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp)
tty->driver_data = acm;
acm->tty = tty;
- /* force low_latency on so that our tty_push actually forces the data through,
- otherwise it is scheduled, and with high data rates data can get lost. */
- tty->low_latency = 1;
if (usb_autopm_get_interface(acm->control) < 0)
goto early_bail;